Resolve issue #4432 with release note text overlap#4451
Merged
michael-hawker merged 2 commits intoCommunityToolkit:mainfrom Jan 13, 2022
Merged
Resolve issue #4432 with release note text overlap#4451michael-hawker merged 2 commits intoCommunityToolkit:mainfrom
michael-hawker merged 2 commits intoCommunityToolkit:mainfrom
Conversation
|
Thanks zateutsch for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested a review
from 
ghost
added
bug 🐛
Arlodotexe
approved these changes
Jan 10, 2022
XAML-Knight
approved these changes
Jan 10, 2022
michael-hawker
approved these changes
Jan 13, 2022
Member
|
Thanks for the fix @zateutsch! 🎉🎉🎉 |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4432
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
Fix for issue 4432 where release notes text was overlapping with dates on About page of Sample App.
What is the new behavior?
Added text trimming to TextBlock where release note name was bound. Will display ellipses if text exceeds width limit of 150.
PR Checklist
Please check if your PR fulfills the following requirements: